[PWGJE] Fixing O2 build errors in jetCorrelationD0 - #17342
Merged
Conversation
MattOckleton
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
August 5, 2026 14:35
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Collaborator
vkucera
previously requested changes
Aug 5, 2026
Comment on lines
357
to
361
| constexpr int kD0ToKPi = 1; | ||
| constexpr int kD0ToKPiPi = 2; | ||
| constexpr int kD0ToPiPi = 3; | ||
| constexpr int kD0ToPiPiPi = 4; | ||
| constexpr int kD0ToKK = 5; |
Collaborator
There was a problem hiding this comment.
Do not redefine existing constants.
Comment on lines
374
to
384
| category = 0; // signal -> D0 or D0bar, π+ K− | ||
| } else if ((d0DecayChannel == kD0ToKPi) && (selectedAs == -1 * matchedFrom)) { | ||
| category = 1; // reflection | ||
| } else if (d0DecayChannel == kD0ToKPiPi) { | ||
| category = 2; // corr bkg: π+ K− π0 | ||
| } else if (d0DecayChannel == kD0ToPiPi) { | ||
| category = 3; // corr bkg: π+ π− | ||
| } else if (d0DecayChannel == kD0ToPiPiPi) { | ||
| category = 4; // corr bkg: π+ π− π0 | ||
| } else if (d0DecayChannel == kD0ToKK) { | ||
| category = 5; // corr bkg: K+ K− |
Collaborator
There was a problem hiding this comment.
Your category values are magic numbers. Define them as enum.
nzardosh
approved these changes
Aug 6, 2026
nzardosh
enabled auto-merge (squash)
August 6, 2026 08:04
nzardosh
dismissed
vkucera’s stale review
August 6, 2026 08:04
Since the requested changes don't impact anything upstream I am merging this now. But Matt please make another PR with Vit's requested changes addressed once this merges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the last pull request was merged, there was a couple of errors in the jetCorrelationD0 task. These are the fixes.